On Tue, Dec 24, 2024 at 05:19:13PM +0800, Andy Yan wrote: > From: Andy Yan <andy.yan@xxxxxxxxxxxxxx> > > The HDPTX PHY on rk3576 is compatible with it on > rk3588. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Add compatible for it. "Add compatible for the HDPTX PHY on rk3576, which is fully compatible with foo bar." One sentence. > > Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx> > --- > > .../devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml > index 84fe59dbcf48..364db2049ce2 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml > @@ -11,8 +11,11 @@ maintainers: > > properties: > compatible: > - enum: > - - rockchip,rk3588-hdptx-phy > + oneOf: > + - const: rockchip,rk3588-hdptx-phy > + - items: Why items? > + - enum: Why enum? > + - rockchip,rk3576-hdptx-phy So that's just enum with previous entry... but you said compatible, yet nothing is here. Test your patches - DTS will fail on this. Driver as well (assuming you expressed properly compatibility). Best regards, Krzysztof
