On Wed, 2024-12-25 at 17:00 +0800, bo.kong wrote:
> From: Bo Kong <Bo.Kong@xxxxxxxxxxxx>
>
> Add a V4L2 sub-device driver for MT8188 AIE.
>
> Signed-off-by: Bo Kong <Bo.Kong@xxxxxxxxxxxx>
> ---
[snip]
> +static void aie_reset_output_buf(struct mtk_aie_dev *fd,
> + struct aie_enq_info *aie_cfg)
> +{
Why clear output buffer?
Could you point out which place in the output buffer that hardware does not write data into but software would read it?
Regards,
CK
> + if (aie_cfg->sel_mode == FDMODE) {
> + memset(fd->rs_output_hw.va, 0, fd->rs_output_hw.size);
> + memset(fd->dma_para->fd_out_hw_va[RPN0_LOOP_NUM][0], 0,
> + RESULT_SIZE);
> + memset(fd->dma_para->fd_out_hw_va[RPN1_LOOP_NUM][0], 0,
> + RESULT_SIZE);
> + memset(fd->dma_para->fd_out_hw_va[RPN2_LOOP_NUM][0], 0,
> + RESULT_SIZE);
> + } else if (aie_cfg->sel_mode == ATTRIBUTEMODE) {
> + memset(fd->base_para->rs_pym_rst_va[0][0], 0,
> + fd->rs_pym_out_size[0]);
> + memset(fd->base_para->rs_pym_rst_va[0][1], 0,
> + fd->rs_pym_out_size[0]);
> + memset(fd->base_para->rs_pym_rst_va[0][2], 0,
> + fd->rs_pym_out_size[0]);
> + } else if (aie_cfg->sel_mode == FLDMODE) {
> + if (fd->variant->fld_enable)
> + memset(fd->fld_para->fld_output_va[0], 0,
> + FLD_MAX_FRAME * FLD_OUTPUT_SIZE);
> + }
> +}
> +
