On Wed, 2024-12-25 at 17:00 +0800, bo.kong wrote: > From: Bo Kong <Bo.Kong@xxxxxxxxxxxx> > > Add a V4L2 sub-device driver for MT8188 AIE. > > Signed-off-by: Bo Kong <Bo.Kong@xxxxxxxxxxxx> > --- [snip] > +// AIE 3.1 > +enum aie_mode { > + FDMODE = 0, > + ATTRIBUTEMODE = 1, > + FLDMODE = 2 > +}; > + Because this patch is a little big, I suggest to break this patch into small patches. I think these three mode could work independently. If so, I suggest break this patch into three patches: 1. Add MT8188 AIE driver (support fd mode only) 2. Add support attribute mode. 3. Add support fld mode. Regards, CK