On 12/21/2024 5:49 AM, Jakub Kicinski wrote:
On Mon, 16 Dec 2024 21:40:26 +0800 Lei Wei wrote:+static int ipq_pcs_config_usxgmii(struct ipq_pcs *qpcs) +{ + int ret; + + /* Configure the XPCS for USXGMII mode if required */ + if (qpcs->interface != PHY_INTERFACE_MODE_USXGMII) {nit: if (qpcs->interface == PHY_INTERFACE_MODE_USXGMII) return 0; And then the entire function doesn't have to be indented.
OK.
Please fix this and repost, it'd be great to get a review tag from Russell or someone with more phylink knowledge.. Please be mindful of: https://lore.kernel.org/all/20241211164022.6a075d3a@xxxxxxxxxx/
Sure, I will post the update once net-next reopens. Thanks.
