Hi Naoki, On Wed, Dec 25, 2024 at 12:22 PM FUKAUMI Naoki <naoki@xxxxxxxxx> wrote: > > The Radxa ROCK 5B+ is an upgraded version of the Radxa ROCK 5B. > > This patch series introduces a shared .dtsi that can be used on the > new Radxa ROCK 5B+, the existing Radxa ROCK 5B, and the upcoming Radxa > ROCK 5T. > > This patch series includes "arm64: dts: rockchip: Add USB-C support to > ROCK 5B" by Sebastian Reichel[1]. > > [1] https://patchwork.kernel.org/project/linux-rockchip/patch/20241210163615.120594-1-sebastian.reichel@xxxxxxxxxxxxx/ > > FUKAUMI Naoki (3): > dt-bindings: arm: rockchip: Add Radxa ROCK 5B+ > arm64: dts: rockchip: Add Radxa ROCK 5B+ > arm64: dts: rockchip: Convert Radxa ROCK 5B to use shared .dtsi This one doesn't look equivalent to the existing ROCK 5B device tree after your changes (I've noticed in particular that fan cooling levels are different - but that's just the part I remember well since I modified it earlier, there might be more differences). Would you mind rearranging the patches so that the split of ROCK 5B dts into a common .dtsi and per-board .dts additions could be made one-to-one equivalent without functional changes, and then add ROCK 5B+ and any other required changes on top of that? See what Dragan did where he prepared parent .dtsi for per-variant OPPs [1] [1] https://lore.kernel.org/linux-rockchip/9ffedc0e2ca7f167d9d795b2a8f43cb9f56a653b.1717923308.git.dsimic@xxxxxxxxxxx/ Best, Alexey
