On 23/12/2024 14:30, Dzmitry Sankouski wrote: > Maxim PMICs may include fuel gauge with additional features, which is > out of single Linux power supply driver scope. > > For example, in max77705 PMIC fuelgauge has additional registers, > like IIN_REG, VSYS_REG, ISYS_REG. Those needed to measure PMIC input > current, system voltage and current respectively. Those measurements > cannot be bound to any of fuelgauge properties. > > The solution here add and option to use max17042 driver as a MFD > sub device, thus allowing any additional functionality be implemented as > another sub device. This will help to reduce code duplication in MFD > fuel gauge drivers. > I did not perform a thorough review, but skimmed through the code. Looks fine. Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof