Hi Andrew, On 04/07/2015 04:44 PM, Andrew Bresticker wrote: [..] > +static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) > +{ > + struct device_node *node = pctl->dev->of_node; > + struct pistachio_gpio_bank *bank; > + unsigned int i; > + int irq, ret = 0; > + > + for (i = 0; i < pctl->nbanks; i++) { > + char child_name[sizeof("gpioXX")]; > + struct device_node *child; The first submission used for_each_child_of_node, and I can't find any review comments explaining why you've changed it to a regular for loop. > + > + snprintf(child_name, sizeof(child_name), "gpio%d", i); This assumes the GPIO bank nodes are called gpio0, gpio1, ... and so on. Do we really want to assume that? Thanks, -- Ezequiel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html