On 19.12.2024 3:42 AM, Jie Gan wrote: > Add following coresight components for QCS8300 platform. > It includes CTI, dummy sink, dynamic Funnel, Replicator, STM, > TPDM, TPDA and TMC ETF. > > Signed-off-by: Jie Gan <quic_jiegan@xxxxxxxxxxx> > --- So I took a look at a bunch of reg values in this patch and the computer tells me they're bound to names similar to the compatible strings (good). This patch is unreviewably long, but at the same time it's made of very repetitive bits. I'm trusting you that you tested out all of these coresight components. I scrolled through a chunk of this, and syntactically it looks good, Rob's bot doesn't seem to complain either, so FWIW: Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> Konrad