Hello Fukaumi,
On 2024-12-23 02:39, FUKAUMI Naoki wrote:
The fan on Radxa ROCK 5C is driven via an AO3416 MOSFET, which has a
total switch-on time of 0,6us and a total switch-off time of 6us [1],
meaning that the current PWM period of just 10us is too short for
fine-grained fan speed control. Increase the PWM period to 60us, so
that the switch-on and switch-off time of the MOSFET fall within a
more reasonable ~10% of the full period, thus making lower PWM duty
cycles meaningful.
[1] https://www.aosmd.com/pdfs/datasheet/AO3416.pdf
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxxx>
As a note, it seems that you forgot to include my Reviewed-by tag
for this patch in the v6. [*]
[*]
https://lore.kernel.org/linux-rockchip/616cd7b81d5469de7bd5a84d2d23387f@xxxxxxxxxxx/
---
Changes in v6:
- none
Changes in v5:
- Reword commit message (Alexey Charkov)
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- Reword commit message
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 23e9b447b6f0..910ec67bd4eb 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -73,7 +73,7 @@ fan {
#cooling-cells = <2>;
cooling-levels = <0 64 128 192 255>;
fan-supply = <&vcc_5v0>;
- pwms = <&pwm3 0 10000 0>;
+ pwms = <&pwm3 0 60000 0>;
};
pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
