Hi Kever, Am Freitag, 20. Dezember 2024, 11:37:48 CET schrieb Kever Yang: > From: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx> > > Add the dt-bindings header for the rk3562, that gets shared between > the clock controller and the clock references in the dts. > Add softreset ID for rk3562. > > Signed-off-by: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx> > Signed-off-by: Liang Chen <cl@xxxxxxxxxxxxxx> > Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx> > +#define CLK_NR_CLKS (CLK_PKA_CRYPTO_S + 1) As Conor already noted, this should not be part of the binding. Instead please use the more modern interfaces we have for determining the max-clk-nr - see rk3576 for example [0] [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/rockchip/clk-rk3576.c#n1730 > + > +/* soft-reset indices */ > + > +/********Name=SOFTRST_CON01,Offset=0x404********/ > +#define SRST_A_TOP_BIU 16 [...] > +/* (0x10200 - 0x400) / 4 * 16 = 260096 */ > +/********Name=PMU0SOFTRST_CON00,Offset=0x10200********/ > +#define SRST_P_PMU0_CRU 260096 > +#define SRST_P_PMU0_PMU 260097 > +#define SRST_PMU0_PMU 260098 [...] > +/********Name=PMU0SOFTRST_CON02,Offset=0x10208********/ > +#define SRST_P_PMU0_I2C0 260136 > +#define SRST_PMU0_I2C0 260137 > + > +/* (0x18200 - 0x400) / 4 * 16 = 391168 */ > +/********Name=PMU1SOFTRST_CON00,Offset=0x18200********/ > +#define SRST_P_PMU1_CRU 391168 [...] > +#define SRST_PMU1_WDTNS 391204 > +#define SRST_PMU1_MAILBOX 391208 > + > +/* (0x20200 - 0x400) / 4 * 16 = 522240 */ > +/********Name=DDRSOFTRST_CON00,Offset=0x20200********/ > +#define SRST_MSCH_BRG_BIU 522244 > +#define SRST_P_MSCH_BIU 522245 Similarly the binding-IDs for the softresets should not contain those huge jumps, instead please use the newer system of mapping IDs to the registers, see rk3576 or rk3588 as example [1] . [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/rockchip/rst-rk3576.c https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/rockchip/rst-rk3588.c Heiko
