Hi Marc, On 12/22/24 18:04, Marc Zyngier wrote:
On Sun, 22 Dec 2024 03:03:53 +0000, FUKAUMI Naoki <naoki@xxxxxxxxx> wrote:Rockchip RK3582 is a scaled down version of Rockchip RK3588(S). Apply Rockchip 3588001 erratum workaround to RK3582. Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxxx> --- drivers/irqchip/irq-gic-v3-its.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 92244cfa0464..c59ce9332dc0 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -4861,7 +4861,8 @@ static bool __maybe_unused its_enable_rk3588001(void *data) { struct its_node *its = data;- if (!of_machine_is_compatible("rockchip,rk3588") &&+ if (!of_machine_is_compatible("rockchip,rk3582") && + !of_machine_is_compatible("rockchip,rk3588") && !of_machine_is_compatible("rockchip,rk3588s")) return false;Please use the relevant property for that purpose ("dma-noncoherent") at the distributor and ITS levels. We're not adding extra compatibles for this anymore, and you might as well fix the core dtsi to expose such property.
I see. I'll drop this patch in v2. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.
Thanks, M.
