On Thu, Dec 19, 2024 at 09:08:18PM +0100, Maya Matuszczyk wrote: > This patch adds bindings for the EC firmware running on IT8987 present > on most of X1E80100 devices Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Maya Matuszczyk <maccraft123mc@xxxxxxxxx> > --- > .../bindings/platform/qcom,x1e-it8987-ec.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/platform/qcom,x1e-it8987-ec.yaml > > diff --git a/Documentation/devicetree/bindings/platform/qcom,x1e-it8987-ec.yaml b/Documentation/devicetree/bindings/platform/qcom,x1e-it8987-ec.yaml > new file mode 100644 > index 000000000000..4a4f6eb63072 > --- /dev/null > +++ b/Documentation/devicetree/bindings/platform/qcom,x1e-it8987-ec.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/platform/qcom,x1e-it8987-ec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Embedded Controller on IT8987 chip. Drop full stop. Titles don't have them. > + > +maintainers: > + - Maya Matuszczyk <maccraft123mc@xxxxxxxxx> > + > +description: > + Most x1e80100 laptops have an EC running on IT8987 MCU chip. The EC controls > + minor functions, like fans, power LED, and on some laptops it also handles > + keyboard hotkeys. > + > +properties: > + compatible: > + oneOf: > + - const: qcom,x1e-it8987-ec That's not a SoC, so I don't understand: 1. referring to the SoC, 2. Having this alone and as fallback. It does not look like you tested the bindings, at least after quick look. Please run 'make dt_binding_check' (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema. Best regards, Krzysztof
