On 19/12/2024 15:25, Krzysztof Kozlowski wrote: > On 19/12/2024 16:07, Vincenzo Frascino wrote: >> Hi Krzysztof, >> >> Thank you for your review. >> >> On 14/12/2024 10:08, Krzysztof Kozlowski wrote: >>> On 13/12/2024 17:32, Vincenzo Frascino wrote: >>>> Add compatibility to Arm Morello System Development Platform. >>>> >>>> Cc: Sudeep Holla <sudeep.holla@xxxxxxx> >>>> Cc: Rob Herring <robh@xxxxxxxxxx> >>>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx> >>>> --- >>>> Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml >>>> index 8dd6b6446394..ea5a5e179ed1 100644 >>>> --- a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml >>>> @@ -118,6 +118,9 @@ properties: >>>> items: >>>> - const: arm,foundation-aarch64 >>>> - const: arm,vexpress >>>> + - description: Arm Morello System Development Platform >>>> + items: >>>> + - const: arm,morello >>> >>> Why is this only SoC? Your commit msg is supposed to explain any >>> oddities, because on first look that's just clearly wrong. >>> >> >> Morello is at the same time the name of an Architecture and of an SoC. >> I will add more information to the commit message in the next iteration. >> >> Could you please provide more information of why you think it is clearly wrong? > > Because there is no board. Usually it is not possible to use SoC alone, > because pinout is too small to connect any wires... > I like your attitude ;) By the way there is a Morello Board as well. I will add it to the commit message in the next iteration. > Best regards, > Krzysztof -- Regards, Vincenzo
