On Thu, Dec 19, 2024 at 01:28:59PM +0100, Krzysztof Kozlowski wrote: > On 19/12/2024 13:18, Christian Marangi wrote: > > Drop NUM_CLOCKS define for EN7581 include. This is not a binding and > > should not be placed here. Value is derived internally in the user > > driver. > > > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > > --- > > Changes v3: > > - Add this patch > > > > include/dt-bindings/clock/en7523-clk.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > > index c4f8a161b981..edfa64045f52 100644 > > --- a/include/dt-bindings/clock/en7523-clk.h > > +++ b/include/dt-bindings/clock/en7523-clk.h > > @@ -14,6 +14,4 @@ > > > > #define EN7581_CLK_EMMC 8 > > > > -#define EN7523_NUM_CLOCKS 8 > Are you sure your patchset bisects? > Well bisectability is a problem. Either this can't be dropped or the change must be shipped with the driver change. > Also better to arrange cleanups before new clocks added, so lack of > conflict between number of clocks and new clock ID is obvious. > ok -- Ansuel
