On 18/12/2024 10:57, Jinlong Mao wrote: > > > On 2024/12/18 17:38, Suzuki K Poulose wrote: >> On 17/12/2024 06:33, Mao Jinlong wrote: >>> For some coresight components like CTI and TPDM, there could be >>> numerous of them. From the node name, we can only get the type and >>> register address of the component. We can't identify the HW or the >>> system the component belongs to. Add label sysfs node support for >>> showing the intuitive name of the device. >>> >>> Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx> >>> --- >>> .../testing/sysfs-bus-coresight-devices-cti | 6 ++++ >>> .../sysfs-bus-coresight-devices-funnel | 6 ++++ >>> .../testing/sysfs-bus-coresight-devices-tpdm | 6 ++++ >>> drivers/hwtracing/coresight/coresight-sysfs.c | 32 +++++++++++++++++++ >>> 4 files changed, 50 insertions(+) >> >> Do you think we need to name the devices using the label ? Or is this >> enough ? >> >> Suzuki > Hi Suzuki, > > In my opinion, we should use label as the device name. As Linux device driver name? No, that's not the point of label. We don't do such stuff, nowhere. Best regards, Krzysztof
