On Mon, Dec 16, 2024 at 10:32:25PM +0100, Heiner Kallweit wrote: > It seems the cpsw MAC doesn't support EEE. See e.g. the commit message of > ce2899428ec0 ("ARM: dts: am335x-baltos: disable EEE for Atheros 8035 PHY"). > There are cases where this causes issues if the PHY's on both sides have > negotiated EEE. As a workaround EEE modes of the PHY are marked broken > in DT, effectively disabling EEE advertisement. > Improve this by using new function phy_disable_eee() in the MAC driver. > This properly disables EEE advertisement, and allows to remove the > eee-broken-xxx properties from DT. As EEE is disabled anyway, we can > remove also the set_eee ethtool op. > > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Andrew