Re: [PATCH v5 3/3] media: dt-bindings: qcom-venus: Deprecate video-decoder and video-encoder where applicable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/12/2024 11:46, Renjiang Han wrote:
> 
> On 12/9/2024 7:52 PM, Bryan O'Donoghue wrote:
>> For the list of yaml files here the video-decoder and video-encoder nodes
>> provide nothing more than configuration input for the driver. These entries
>> do not in fact impart hardware specific data and should be deprecated.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>> ---


Please kindly trim the replies from unnecessary context. It makes it
much easier to find new content.

>> @@ -132,12 +132,4 @@ examples:
>>           resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>,
>>                    <&videocc VIDEO_CC_MVS0C_CLK_ARES>;
>>           reset-names = "bus", "core";
>> -
>> -        video-decoder {
>> -            compatible = "venus-decoder";
>> -        };
>> -
>> -        video-encoder {
>> -            compatible = "venus-encoder";
>> -        };
>>       };
> It is working fine on QCS615.
> Tested-by: Renjiang Han <quic_renjiang@xxxxxxxxxxx>


How? How is it possible to test a binding on real hardware? To my
knowledge it is impossible, so I really would like to see explanation of
this tag.

I recently voiced my concerns that I really dislike tested-by tags on
bindings, because they are fake or not accurate. Story continues...



Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux