On 12/13/2024 6:30 PM, Konrad Dybcio wrote: > On 25.11.2024 6:07 AM, Manikanta Mylavarapu wrote: >> IPQ5424 has tsens v2.3.3 peripheral. This patch adds the tsens >> node with nvmem cells for calibration data. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx> >> --- > > [...] > >> + tsens: thermal-sensor@4a9000 { >> + compatible = "qcom,ipq5424-tsens"; >> + reg = <0 0x004a9000 0 0x1000>, >> + <0 0x004a8000 0 0x1000>; >> + nvmem-cells = <&tsens_mode>, >> + <&tsens_base0>, >> + <&tsens_base1>, >> + <&tsens_sens9_off>, >> + <&tsens_sens10_off>, >> + <&tsens_sens11_off>, >> + <&tsens_sens12_off>, >> + <&tsens_sens13_off>, >> + <&tsens_sens14_off>, >> + <&tsens_sens15_off>; >> + nvmem-cell-names = "mode", >> + "base0", >> + "base1", >> + "tsens_sens9_off", >> + "tsens_sens10_off", >> + "tsens_sens11_off", >> + "tsens_sens12_off", >> + "tsens_sens13_off", >> + "tsens_sens14_off", >> + "tsens_sens15_off"; >> + interrupts = <GIC_SPI 105 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "combined"; >> + #qcom,sensors = <7>; >> + #thermal-sensor-cells = <1>; >> + }; > > Please move interrupts properties above nvmem > Sure, i will update in the next version. Thanks & Regards, Manikanta. > with that: > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> > > Konrad