On Tue, Dec 17, 2024 at 04:43:19PM +0100, AngeloGioacchino Del Regno wrote:
> + i2c:
> + type: object
> + $ref: /schemas/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml
> + unevaluatedProperties: false
> + description: HDMI DDC I2C controller
> +
> + phys:
> + maxItems: 1
> + description: PHY providing clocking TMDS and pixel to controller
> +
> + phy-names:
> + items:
> + - const: hdmi
> +
> + pinctrl-0: true
> +
> + pinctrl-names:
> + items:
> + - const: default
Drop both pinctrl entries.
> +
> + power-domains:
> + maxItems: 1
> +
> + '#sound-dai-cells':
> + const: 1
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Input port, usually connected to the output port of a DPI
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Output port that must be connected either to the input port of
> + a HDMI connector node containing a ddc-i2c-bus, or to the input
> + port of an attached bridge chip, such as a SlimPort transmitter.
> +
> + required:
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
Please keep the same order of things here and in main properties
section.
> + - interrupts
> + - power-domains
> + - phys
> + - phy-names
> + - ports
> +
You need allOf: with ref to dai-common.yaml.
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/mt8195-power.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + hdmi-tx@1c300000 {
hdmi@
Best regards,
Krzysztof
