On 18/12/2024 04:04, Kevin Chen wrote: > Hi Krzk, > >>> 1. Because size-cells is no need to use 2, modify to 1 for use. >> >> ??? > So, is it OK that I change the size-cells back to 2 include the aspeed,ast2700-intc.yaml examples and aspeed-g7.dtsi? No, my total surprise is that I did not understand what it maens. Is this changelog? Commit msg? Why such change is made? > >> >>> 2. Add minItems to 1 for interrupts for intc1. >> >> ??? > For variable interrupt numbers, I need to fix the below warnings by minItems. > DTC [C] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb > /home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@100: interrupts-extended: [[3, 0, 3844]] is too short > from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > /home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@110: interrupts-extended: [[3, 1, 3844]] is too short > from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > /home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@120: interrupts-extended: [[3, 2, 3844]] is too short > from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > /home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@130: interrupts-extended: [[3, 3, 3844]] is too short > from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > /home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@140: interrupts-extended: [[3, 4, 3844]] is too short > from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > /home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@150: interrupts-extended: [[3, 5, 3844]] is too short > from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > >> >>> 3. Add 1 interrupt of intc1 example into yaml file. >> >>> 4. Add intc1 sub-module of uart12 as example using the intc0 and intc1. >> >> What is all this? >> >> BTW, there was no such patch in previous version and your changelog is silent >> about it. > Agree, I will restore the previous version. > >> >> Subject: drop all full stops. Subject never ends with full stop. >> >>> --- >>> .../aspeed,ast2700-intc.yaml | 60 >> +++++++++++++++---- >>> 1 file changed, 47 insertions(+), 13 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270 >>> 0-intc.yaml >>> b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270 >>> 0-intc.yaml index 55636d06a674..eadfbc45326b 100644 >>> --- >>> a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270 >>> 0-intc.yaml >>> +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,as >>> +++ t2700-intc.yaml >>> @@ -31,6 +31,7 @@ properties: >>> type as defined in interrupt.txt in this directory. >>> >>> interrupts: >>> + minItems: 1 >> >> Nope, not explained, not constrained. Your schema is supposed to be >> constrained. I still do not understand this commit at all. Best regards, Krzysztof
