Hi Sakari, On Sun, Dec 15, 2024 at 12:18:42PM +0000, Sakari Ailus wrote: > Hi Alain, > > On Thu, Dec 12, 2024 at 10:17:26AM +0100, Alain Volmat wrote: > > Add the stm32 csi controller description. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx> > > --- > > v2: > > - rename into st,stm32mp25-csi.yaml to match compatible > > - correct port / data-lanes (remove useless lines & > > use data-lanes 1 and 2 instead of 0 and 1) > > - correct commit log > > --- > > .../bindings/media/st,stm32mp25-csi.yaml | 125 +++++++++++++++++++++ > > 1 file changed, 125 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > > new file mode 100644 > > index 000000000000..33bedfe41924 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > > @@ -0,0 +1,125 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/st,stm32mp25-csi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: STMicroelectronics STM32 CSI controller > > + > > +description: > > + The STM32 CSI controller allows connecting a CSI based > > + camera to the DCMIPP camera pipeline. > > CSI-2 I presume? > > You should also document it here it has D-PHY... > > > + > > +maintainers: > > + - Alain Volmat <alain.volmat@xxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - st,stm32mp25-csi > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 3 > > + > > + clock-names: > > + items: > > + - const: pclk > > + - const: txesc > > + - const: csi2phy > > + > > + resets: > > + maxItems: 1 > > + > > + vdd-supply: > > + description: Digital core power supply (0.91V) > > + > > + vdda18-supply: > > + description: System analog power supply (1.8V) > > + > > + access-controllers: > > + minItems: 1 > > + maxItems: 2 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + Input port node > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + > > + required: > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Output port node > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - resets > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/st,stm32mp25-rcc.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/media/video-interfaces.h> > > + #include <dt-bindings/reset/st,stm32mp25-rcc.h> > > + csi@48020000 { > > + compatible = "st,stm32mp25-csi"; > > + reg = <0x48020000 0x2000>; > > + interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>; > > + resets = <&rcc CSI_R>; > > + clocks = <&rcc CK_KER_CSI>, <&rcc CK_KER_CSITXESC>, <&rcc CK_KER_CSIPHY>; > > + clock-names = "pclk", "txesc", "csi2phy"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + port@0 { > > + reg = <0>; > > + endpoint { > > + remote-endpoint = <&imx335_ep>; > > + data-lanes = <1 2>; > > + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>; > > ...and drop bus-type property. > > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + endpoint { > > + remote-endpoint = <&dcmipp_0>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > all 3 points corrected within the new serie I just pushed on top of this one since it has already been merged. Regards, Alain
