Hello, Please review the version 3 of patchset. V4: --- - Improved commit message. V3: --- - Improved documentation as per suggestion. - Fixed issues in the probe function. - Add ACKed string in the commit message V2: --- - Fixed documentation issues. - Added pmbus revision debugfs file in the core - Remove debugfs and read word from crps185 - Improved commit messages Ninad Palsule (4): hwmon: (pmbus/core) Add PMBUS_REVISION in debugfs hwmon: (pmbus/crps) Add Intel CRPS185 power supply dt-bindings: hwmon: intel,crps185: Add to trivial ARM: dts: aspeed: system1: Use crps PSU driver .../devicetree/bindings/trivial-devices.yaml | 2 + Documentation/hwmon/crps.rst | 97 +++++++++++++++++++ Documentation/hwmon/index.rst | 1 + MAINTAINERS | 7 ++ .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 8 +- drivers/hwmon/pmbus/Kconfig | 9 ++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/crps.c | 74 ++++++++++++++ drivers/hwmon/pmbus/pmbus_core.c | 13 ++- 9 files changed, 206 insertions(+), 6 deletions(-) create mode 100644 Documentation/hwmon/crps.rst create mode 100644 drivers/hwmon/pmbus/crps.c -- 2.43.0