On Tue, Dec 17, 2024 at 10:38:51AM -0600, Bjorn Andersson wrote: > > On Fri, 06 Dec 2024 18:24:02 +0100, Johan Hovold wrote: > > This reverts commit 1a48dd7b9ac809d1bd0fd2fef509abba83433846. > > > > A recent change enabling OTG mode on the Lenovo ThinkPad T14s USB-C > > ports can break SuperSpeed device hotplugging. The host controller is > > enumerated, but the device is not: > > > > xhci-hcd xhci-hcd.5.auto: xHCI Host Controller > > xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 3 > > xhci-hcd xhci-hcd.5.auto: hcc params 0x0110ffc5 hci version 0x110 quirks 0x000080a000000810 > > xhci-hcd xhci-hcd.5.auto: irq 247, io mem 0x0a800000 > > xhci-hcd xhci-hcd.5.auto: xHCI Host Controller > > xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 4 > > xhci-hcd xhci-hcd.5.auto: Host supports USB 3.1 Enhanced SuperSpeed > > hub 3-0:1.0: USB hub found > > hub 3-0:1.0: 1 port detected > > hub 4-0:1.0: USB hub found > > hub 4-0:1.0: 1 port detected > > > > [...] > > Applied, thanks! > > [1/1] Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports" > commit: 1fb5cf0d165afc3be76ec754d1b1013515c3896a Oh, you appear to have picked v1 here. We need to revert also the other two patches from that series to address a suspend issue and to unbreak UCSI and DP support: https://lore.kernel.org/lkml/20241210111444.26240-1-johan+linaro@xxxxxxxxxx/ Johan
