On Mon, Dec 09, 2024 at 09:26:33PM +0100, Marek Vasut wrote: > On 12/9/24 7:22 PM, Andrew Lunn wrote: > > On Mon, Dec 09, 2024 at 06:58:50PM +0100, Fedor Ross wrote: > > > Add support for the led-mode property for the following PHYs which have > > > a single LED mode configuration value. > > > > > > KSZ8765, KSZ8794 and KSZ8795 use register 0x0b bits 5,4 to control the > > > LED configuration. > > > > > > KSZ8863 and KSZ8873 use register 0xc3 bits 5,4 to control the LED > > > configuration. > > > > PHY and MAC LEDs should be configured via /sys/class/leds. Please take > > a look at how the Marvell PHY and DSA driver, qca8k driver etc do > > LEDs. > According to KSZ8794 datasheet, this register 0xb is Global Control: > > Register 11 (0x0B): Global Control 9 > > So this does not seems like per-port LED control, but rather some global > control for all LEDs on all ports on the chip ? Still should be able to use the standard binding and sysfs controls. The driver just has to reject invalid combinations. Rob
