Re: [PATCH v5 3/7] dt-bindings: display: renesas,du: Add missing constraints

Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> · Tue, 17 Dec 2024 11:59:53 +0200

Hi,

On 17/12/2024 10:14, Geert Uytterhoeven wrote:
Hi Tomi,

On Tue, Dec 17, 2024 at 6:32 AM Tomi Valkeinen
<tomi.valkeinen@xxxxxxxxxxxxxxxx> wrote:
From: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>

The binding is missing maxItems for all renesas,cmms and renesas,vsps
properties. As the amount of cmms or vsps is always a fixed amount, set
the maxItems to match the minItems.

Also add the minItems and maxItems to the top level properties.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>

Thanks for your patch!

--- a/Documentation/devicetree/bindings/display/renesas,du.yaml
+++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
@@ -77,6 +77,8 @@ properties:

    renesas,cmms:
      $ref: /schemas/types.yaml#/definitions/phandle-array
+    minItems: 1
+    maxItems: 4
      items:
        maxItems: 1
      description:
@@ -85,6 +87,8 @@ properties:

    renesas,vsps:
      $ref: /schemas/types.yaml#/definitions/phandle-array
+    minItems: 1
+    maxItems: 4
      items:
        items:
          - description: phandle to VSP instance that serves the DU channel
@@ -489,9 +493,11 @@ allOf:

          renesas,cmms:
            minItems: 4
+          maxItems: 4

          renesas,vsps:
            minItems: 4
+          maxItems: 4

AFAIK these two additions are not needed, as they already match the
values defined at the top level.

But if we add a new SoC, which has 5 vsps, we would need to increase the 
values in the top level. Which would then mean these are needed, and I'm 
sure adding them could be missed.

 Tomi








