Hi Krzysztof Kozlowski, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 17 December 2024 09:00 > Subject: Re: [PATCH v4 1/7] dt-bindings: pinctrl: renesas: Add alpha-numerical port support for RZ/V2H > > On 17/12/2024 09:49, Biju Das wrote: > > Hi Krzysztof Kozlowski, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > >> Sent: 17 December 2024 07:51 > >> Subject: Re: [PATCH v4 1/7] dt-bindings: pinctrl: renesas: Add > >> alpha-numerical port support for RZ/V2H > >> > >> On 17/12/2024 08:29, Biju Das wrote: > >>> Hi Krzysztof Kozlowski, > >>> > >>> Thanks for the feedback. > >>> > >>>> -----Original Message----- > >>>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > >>>> Sent: 17 December 2024 06:32 > >>>> Subject: Re: [PATCH v4 1/7] dt-bindings: pinctrl: renesas: Add > >>>> alpha-numerical port support for RZ/V2H > >>>> > >>>> On Mon, Dec 16, 2024 at 07:53:11PM +0000, Biju Das wrote: > >>>>> RZ/V2H has ports P0-P9 and PA-PB. Add support for defining > >>>>> alpha-numerical ports in DT using RZV2H_* macros. > >>>> > >>>> So this is only for DT? Not really a binding. Binding binds driver > >>>> implementation with DTS and you do not have here driver. > >>> > >>> Please see patch [1], see how this definition binds driver > >>> implementation with DTS > >>> > >>> [1] > >>> https://lore.kernel.org/all/20241216195325.164212-4-biju.das.jz@bp.r > >>> en > >>> esas.com/ > >> > >> I don't know what is this patch, it is not part of these series > >> addressed to me and commit msg says "in DT". If you want to receive meaningful review, make it > easier for reviewers. > > > > The header files are part of DT bindings. So if it is wrong, why the > > Commit "997daa8de64ccbb" "dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings" > > is part of bindings? > > I meant that driver patch you linked. > > > > > > > > >> > >> > >>> > >>>> > >>>> Calling it a binding makes it immutable and gives us, DT > >>>> maintainers, more work, so really no benefits at all. > >>> > >>>> > >>>> I guess other DT maintainers will ack it, I prefer to reduce number of headers. > >>> > >>> DT describes hardware. The port names are alpha numeric on hardware manual. > >> > >> We talk about binding, not DT. > > > > Bu the definitions are part of bindings just like Commit "997daa8de64ccbb". > > You made them part of bindings, but this is invalid as argument. How is this anyhow related? How is > "DT describes hardware" part of binding? > > You said "DT describes hardware", but we do not talk here about DT, do we? We talk about binding. OK. > I am not going to keep reading all the external references you keep bringing or discussing why someone > else did something. This patch must be logical and correct on its own, not because someone else made > something somewhere. OK. According to me this patch is correct. It is for DT user and it described clearly in commit message "RZ/V2H has ports P0-P9 and PA-PB. Add support for defining alpha-numerical ports in DT using RZV2H_* macros." Geert, Please suggest should we merge this patch with the dts patch to avoid confusion?? Cheers, Biju
