On Mon, Dec 16, 2024 at 03:35:12PM +0800, Geoffrey Chien wrote: > Add Skitty initial device tree. > Support second source Synaptics trackpad > Support US2 keyboard. > Enhance touch screen timing for ELAN > Based on experiment, set drive-strength to 6mA (default = 8mA) > Modify sbs battery reg to 0x0f > > Signed-off-by: Geoffrey Chien <geoffrey_chien@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/arm/mediatek.yaml | 8 +++ > arch/arm64/boot/dts/mediatek/Makefile | 4 ++ > .../dts/mediatek/mt8186-corsola-skitty-sku1.dts | 23 +++++++ > .../dts/mediatek/mt8186-corsola-skitty-sku2.dts | 13 ++++ > .../dts/mediatek/mt8186-corsola-skitty-sku3.dts | 40 ++++++++++++ > .../dts/mediatek/mt8186-corsola-skitty-sku4.dts | 30 +++++++++ > .../boot/dts/mediatek/mt8186-corsola-skitty.dtsi | 76 ++++++++++++++++++++++ This wasn't ever tested (as robots point out), but also: It does not look like you tested the DTS against bindings. Please run 'make dtbs_check W=1' (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema. Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > 7 files changed, 194 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 1d4bb50fcd8d9aadb7b77e144a474b79da005056..29e7555569a772ba042e29af01ea98fdd3be1525 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -224,6 +224,14 @@ properties: > - google,pico-sku2 > - const: google,pico > - const: mediatek,mt8183 > + - description: Google Skitty (HP Chromebook G1m 11 inch) > + items: > + - const: google,skitty-sku1 > + - const: google,skitty-sku2 > + - const: google,skitty-sku3 > + - const: google,skitty-sku4 > + - const: google,skitty > + - const: mediatek,mt8186 > - description: Google Willow (Acer Chromebook 311 C722/C722T) > items: > - enum: > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 8fd7b2bb7a1590341e7bb4ea1ecf039ae3e8eb0d..328e1ee444bd81b5a2aa3d21acb7a5c5a3318a87 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -59,6 +59,10 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393216.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393217.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-rusty-sku196608.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku1.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku2.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku3.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku4.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131072.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131073.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-tentacool-sku327681.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts > new file mode 100644 > index 0000000000000000000000000000000000000000..a0e7b10445333d6f83fc4c461ce8f8d75ffaa697 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2024 Google LLC > + */ > + > +/dts-v1/; > +#include "mt8186-corsola-skitty.dtsi" > + > +/ { > + model = "Google Skitty sku1 board"; > + compatible = "google,skitty-sku1", > + "google,skitty", "google,corsola", "mediatek,mt8186"; Fix alignment. Best regards, Krzysztof
