On 12/13/2024 7:31 PM, Bryan O'Donoghue wrote:
On 13/12/2024 09:56, Renjiang Han wrote:
+ video-decoder {
+ compatible = "venus-decoder";
+ };
+
+ video-encoder {
+ compatible = "venus-encoder";
+ };
To be honest, I'd prefer not to continue on doing this.
Adding a compat string to existing yaml might work-around the issue
but, it doesn't really _account_ for the issue.
I've posted a series to fix the problem
20241209-media-staging-24-11-25-rb3-hw-compat-string-v5-0-ef7e5f85f302@xxxxxxxxxx
Either that or deeper rewrite of venus to remove the above
dependencies should go ahead.
I'm not in favour of willfully continuing to do the wrong thing,
especially when per above, there's a working solution for it.
---
bod
Thanks for your review. Your change is a good way. But your change is a
big change, involving many platforms, I am not sure if other guys have
comments. Currently, my change only refers to SC7180 and falls back QCS615
to SC7180. Now I have verified my patches on SC7180 and QCS615. I think if
your change has passed the review, then we only need to remove the
video-decoder and video-encoder nodes in this device tree.
--
Best Regards,
Renjiang
