Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-12-16 15:38, FUKAUMI Naoki wrote:
On 12/16/24 23:27, Krzysztof Kozlowski wrote:
On 16/12/2024 15:19, FUKAUMI Naoki wrote:
On 12/16/24 22:56, Krzysztof Kozlowski wrote:
On 16/12/2024 14:48, FUKAUMI Naoki wrote:
On 12/16/24 22:37, Krzysztof Kozlowski wrote:
On 16/12/2024 12:30, FUKAUMI Naoki wrote:
Use more common name "pwm-fan" for pwm-fan node. No functinal change.

No, generic name is fan.

https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@xxxxxxxxxxx/

And? That's incorrect advice.  There is no such device as "pwm-fan".
There is a "fan" and whether it is pwm or gpio it does not matter.

See DT spec and generic names recommendation.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67

Is it wrong?
Yes.

Okay, please fix it.

Good point.

Feel free to use:

Reported-by: FUKAUMI Naoki <naoki@xxxxxxxxx>





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux