Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Krzysztof,

On 2024-12-16 14:42, Krzysztof Kozlowski wrote:
On 16/12/2024 13:43, Dragan Simic wrote:
On 2024-12-16 12:30, FUKAUMI Naoki wrote:
Use more common name "pwm-fan" for pwm-fan node. No functinal change.

Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxxx>

Looking good to me, as a preparatory patch.  Please, feel free
to include:

Reviewed-by: Dragan Simic <dsimic@xxxxxxxxxxx>

That's just incorrect. If you really want to review such trivial
patches, perform a full review.

Well, I don't see what's wrong with reviewing two fan-related patches
that go together?  Moreover, in this case it's about using a generic
name, which you prefer, or using a more common name, which I prefer.
However, as a maintainer, your preference matters more.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux