Hi Krzk,
> > Add EVB board of AST2700 in ASPEED Architecture.
> >
> > Signed-off-by: Kevin Chen <kevin_chen@xxxxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/aspeed/Makefile | 4 ++
> > arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 57
> > ++++++++++++++++++++++
> > 2 files changed, 61 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/aspeed/Makefile
> > create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> >
> > diff --git a/arch/arm64/boot/dts/aspeed/Makefile
> > b/arch/arm64/boot/dts/aspeed/Makefile
> > new file mode 100644
> > index 000000000000..ffe7e15017cc
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/aspeed/Makefile
> > @@ -0,0 +1,4 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +dtb-$(CONFIG_ARCH_ASPEED) += \
> > + ast2700-evb.dtb
> > diff --git a/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> > b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> > new file mode 100644
> > index 000000000000..6dad88c98ce0
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> > @@ -0,0 +1,57 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +
> > +/dts-v1/;
> > +
> > +#include "aspeed-g7.dtsi"
> > +#include <dt-bindings/gpio/aspeed-gpio.h>
> > +
> > +/ {
> > + model = "AST2700A1-EVB";
> > + compatible = "aspeed,ast2700-evb", "aspeed,ast2700";
> > +
> > + aliases {
> > + serial12 = &uart12;
> > + };
> > +
> > + chosen {
> > + bootargs = "console=ttyS12,115200n8";
> > + stdout-path = &uart12;
>
> Nothing improved. You keep ignoring my comments: not responding, not
> addressing, not fixing the code.
OK. I will remove the bootargs.
>
> > + };
> > +
> > + firmware {
> > + optee: optee {
> > + compatible = "linaro,optee-tz";
> > + method = "smc";
> > + };
> > + };
> > +
> > + memory@400000000 {
> > + device_type = "memory";
> > + reg = <0x4 0x00000000 0x40000000>;
> > + };
> > +
> > + reserved-memory {
> > + #address-cells = <2>;
> > + #size-cells = <1>;
> > + ranges;
> > +
> > + mcu_fw: mcu-firmware@42fe00000 {
> > + reg = <0x4 0x2fe00000 0x200000>;
> > + no-map;
> > + };
> > +
> > + atf: trusted-firmware-a@430000000 {
> > + reg = <0x4 0x30000000 0x80000>;
> > + no-map;
> > + };
> > +
> > + optee_core: optee_core@430080000 {
>
> Follow DTS Coding style document. That's the same comment as before.
OK. I will fix to optee-core:optee-core@430080000 {
>
>
> Best regards,
> Krzysztof
