Re: [PATCH 2/2] clk: cs2600: Add Fractional-N clock driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2024 at 11:58:07AM +0100, Krzysztof Kozlowski wrote:
> > +
> > +#include "clk-cs2600.h"
> 
> You do not include here even the bindings, so clearly
> CS2600_AUX_OUTPUT_FREQ_UNLOCK and others are not bindings.
> 
Ack.  I will change this.

> ID table definition goes here or somewhere around the probe.
> 
Ack.

> > +static struct i2c_driver cs2600_driver = {
> > +	.driver = {
> > +		.name = "cs2600",
> > +		.of_match_table = cs2600_of_match,
> > +	},
> > +	.probe		= cs2600_i2c_probe,
> > +	.id_table	= cs2600_id,
> > +};
> > +
> > +module_i2c_driver(cs2600_driver);
> > +

Regards,
Paul
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux