On Sun, Dec 15, 2024 at 1:36 PM Vasily Khoruzhick <anarsoul@xxxxxxxxx> wrote:
>
> Since commit ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux"),
> TCON0 clock parent is always set to PLL_MIPI, but unfortunately it breaks
> video output on Pinebook.
>
> I did an experiment: I manually configured PLL_MIPI and PLL_VIDEO0_2X
> to the same clock rate and flipped the switch with devmem. Experiment clearly
> showed that whenever PLL_MIPI is selected as TCON0 clock parent, the video
> output stops working.
>
> To fix the issue, I partially reverted mentioned commit and added explicit
> TCON0 clock parent assignment to device tree. By default, it will be
> PLL_MIPI, and the only users with RGB output - Pinebook and Teres-I will
> override it in their dts.
>
> Vasily Khoruzhick (3):
> dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and PLL_MIPI
> arm64: dts: allwinner: a64: explicitly assign clock parent for TCON0
> clk: sunxi-ng: a64: stop force-selecting PLL-MIPI as TCON0 parent
Looks good to me.
Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
I'll wait for a bit for Andre to comment.
> arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 2 ++
> arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 2 ++
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 ++
> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 11 -----------
> drivers/clk/sunxi-ng/ccu-sun50i-a64.h | 2 --
> include/dt-bindings/clock/sun50i-a64-ccu.h | 2 ++
> 6 files changed, 8 insertions(+), 13 deletions(-)
>
> --
> 2.47.1
>
