Re: [PATCH v7 5/5] arm64: dts: qcom: sdm670: add camss and cci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2024 at 11:12:02PM -0500, Richard Acayan wrote:
> On Wed, Dec 11, 2024 at 11:24:30AM +0000, Bryan O'Donoghue wrote:
> > On 11/12/2024 00:30, Richard Acayan wrote:
> > > > I think you sorted the regs, interrupts but forgot the clocks ?
> > > Do you mean the first three clocks placed first? The order was suggested
> > > by Vladimir in [1], but I can undo it.
> > > 
> > > [1]https://lore.kernel.org/r/40cd7a52-1c60-40dc-aee6-730b5247b216@xxxxxxxxxx
> > 
> > We've had a long, long discussion on ordering subsequent.
> > 
> > Have a look at the sc7280 and align your ordering with that.
> 
> Ok, it seems SC7280 renames the CSID clocks to change their alphabetical
> sorting so I'll rename them as well.
> 
> 	csi0 -> vfe0_csid
> 	csi1 -> vfe1_csid
> 	csi2 -> vfe_lite_csid

Let's not do this, the "csiX" clock names are also used in camss-csid.c
and would need deeper driver changes.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux