On Fri, Dec 13, 2024 at 08:52:49AM +0100, Krzysztof Kozlowski wrote: > On 12/12/2024 09:24, Peng Fan (OSS) wrote: > > + > > + if (imx_ele_ocotp_check_access(pdev, id)) { > > + of_detach_node(child); > > + dev_err(dev, "%s: Not granted, device driver will not be probed\n", > > + child->full_name); > > + } > > + } > > + > > + imx_ele_ocotp_grant_access(pdev, child); > > + } > > + > > + return 0; > > +} > > + > > +static int imx_ele_ocotp_access_control(struct platform_device *pdev) > > +{ > > + struct imx_ocotp_priv *priv = platform_get_drvdata(pdev); > > + struct device_node *soc __free(device_node) = of_find_node_by_path("/soc"); > > No, you just created undocumented ABI on the name. > > Drop/replace or express the ABI (which is impossible, so basically: drop). How about iterate whole tree by use bfs method? So no undocumented ABI. Frank > > > Best regards, > Krzysztof