On Fri, Dec 13, 2024 at 12:01:40PM +0100, Krzysztof Kozlowski wrote: > On Wed, Dec 11, 2024 at 12:22:37PM +0100, Christian Marangi wrote: > > Add ID for eMMC for EN7581. This is to control clock selection of eMMC > > between 200MHz and 150MHz. > > > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > > --- > > include/dt-bindings/clock/en7523-clk.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > > index 717d23a5e5ae..78d16068228a 100644 > > --- a/include/dt-bindings/clock/en7523-clk.h > > +++ b/include/dt-bindings/clock/en7523-clk.h > > @@ -11,7 +11,8 @@ > > #define EN7523_CLK_NPU 5 > > #define EN7523_CLK_CRYPTO 6 > > #define EN7523_CLK_PCIE 7 > > +#define EN7581_CLK_EMMC 8 > > > > -#define EN7523_NUM_CLOCKS 8 > > +#define EN7523_NUM_CLOCKS 9 > > This cannot change. > > If this changes, then it is not a binding and first drop it in separate > patch. > > Best regards, > Krzysztof > Hi Krzysztof, maybe I can introduce EN7581_NUM_CLOCKS with the correct number? Just to give more info about this... It's not clear to me why NUM_CLOCKS is needed considering is only needed in clk-en7523.c to probe the driver and allock memory... Anyway is a different define OK for you? -- Ansuel
