Hello.
On 04/02/2015 04:56 PM, Ben Hutchings wrote:
This driver looks somewhat similar to sh-eth, but lacks some of the
recent bug fixes made to that. At least commit 283e38db65e7 ("sh_eth:
Fix serialisation of interrupt disable with interrupt & NAPI handler")
appears to be applicable, but there are probably others.
I suspect this issue applies to many drivers...
I couldn't reproduce the bug that patch was fixing, so left this fix out
for the time being. Others cases were fixed (if applicable).
One feature request:
On Sat, 2015-03-28 at 02:13 +0300, Sergei Shtylyov wrote:
[...]
+/* ioctl to device function */
+static int ravb_do_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
+{
+ struct ravb_private *priv = netdev_priv(ndev);
+ struct phy_device *phydev = priv->phydev;
+
+ if (!netif_running(ndev))
+ return -EINVAL;
+
+ if (!phydev)
+ return -ENODEV;
+
+ if (cmd == SIOCSHWTSTAMP)
+ return ravb_hwtstamp_ioctl(ndev, req, cmd);
[...]
The driver should also handle SIOCGHWTSTAMP.
Done.
Ben.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
