On 11/13/2024 10:11 PM, Frank Li wrote: > On Wed, Nov 13, 2024 at 02:52:38PM -0500, Laurentiu Mihalcea wrote: >> From: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx> >> >> Introduce the 'widgets' property, allowing the creation of widgets from >> 4 template widgets: Microphone, Line, Headphone, and Speaker. Also >> introduce the 'hp-det-gpios' property, which allows using headphone >> detection using the specified GPIO. >> >> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx> >> --- >> .../devicetree/bindings/sound/audio-graph-card2.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml >> index f943f90d8b15..94588353f852 100644 >> --- a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml >> +++ b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml >> @@ -37,6 +37,10 @@ properties: >> codec2codec: >> type: object >> description: Codec to Codec node >> + hp-det-gpios: >> + $ref: audio-graph.yaml#/properties/hp-det-gpios >> + widgets: >> + $ref: audio-graph.yaml#/properties/widgets > why not direct ref Documentation/devicetree/bindings/sound/audio-graph.yaml > and define these again here. We don't actually want all the properties from 'audio-graph.yaml' (for the moment at least). Also ref-ing 'audio-graph.yaml' will make the 'dais' property required, which is not targeted in this patch. Maybe Kuninori Morimoto can comment more on this. > > Frank > >> required: >> - compatible >> -- >> 2.34.1 >>
