On Wed, Dec 11, 2024 at 11:06:45PM +0000, Lothar Rubusch wrote: > Remove interrupts from the list of required properties. The ADXL345 > provides two interrupt lines. Anyway, the interrupts are an option, to > be used for additional event features. The driver can measure without > interrupts. Hence, interrupts should never have been required for the > ADXL345. Thus having interrupts required can be considered to be a > mistake. Partially this explains my question on previous patch, so consider reordering them. And with combined knowledge, your driver now depends on interrupt names to setup interrupts. "interrupts" property alone is not sufficient, so you should encode it in the binding and explain in rationale why this is required (it is a change in ABI). https://elixir.bootlin.com/linux/v6.8-rc3/source/Documentation/devicetree/bindings/example-schema.yaml#L193 Best regards, Krzysztof
