Hi Alex, On 12/11/24 11:42 AM, Alexandre ARNOUD wrote: > Hello Cristian, > >> On 11 Dec 2024, at 12:06 AM, Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> wrote: >> >> Changes in v2: >> - Override hdmi1 pinctrl-0 on rock-5b as it requires hdmim0_tx1_cec >> instead of hdmim2_tx1_cec (fixes a pin conflict when enabling >> CONFIG_SPI_ROCKCHIP_SFC) >> - Link to v1: https://lore.kernel.org/r/20241207-rk3588-hdmi1-v1-0-ca3a99b46a40@xxxxxxxxxxxxx >> >> --- >> Cristian Ciocaltea (4): >> drm/rockchip: dw_hdmi_qp: Add support for RK3588 HDMI1 output >> arm64: dts: rockchip: Add PHY node for HDMI1 TX port on RK3588 >> arm64: dts: rockchip: Add HDMI1 node on RK3588 >> arm64: dts: rockchip: Enable HDMI1 on rock-5b >> >> arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi | 62 ++++++++++++ >> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 44 ++++++++- >> drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 119 +++++++++++++++++++----- >> 3 files changed, 200 insertions(+), 25 deletions(-) >> --- >> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 >> change-id: 20241207-rk3588-hdmi1-704cbb7cd75f > > Tested-by: Alexandre ARNOUD <aarnoud@xxxxxx> > > Works perfectly on Rock-5B, thanks for your work. Thanks for your quick test report on the series, which helped identifying the pin conflict issue which I missed initially. Regards, Cristian