On Tue, Dec 10, 2024 at 04:27:02PM -0500, Frank Li wrote: > +description: > + i.MX91 features a new temperature sensor. It includes programmable > + temperature threshold comparators for both normal and privileged > + accesses and allows a programmable measurement frequency for the > + Periodic One-Shot Measurement mode. Additionally, it provides > + status registers for indicating the end of measurement and threshold > + violation events. > + Missing ref to thermal-sensor.yaml > +properties: > + compatible: > + items: > + - const: fsl,imx91-tmu > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + nvmem-cells: > + items: > + - description: Phandle to the trim control 1 provided by ocotp > + - description: Phandle to the trim control 2 provided by ocotp > + > + nvmem-cell-names: > + items: > + - const: trim1 > + - const: trim2 > + > + "#thermal-sensor-cells": > + enum: [0, 1] Why this is flexible? How many sensors do you have there? > + > +required: > + - compatible > + - reg > + - clocks > + - '#thermal-sensor-cells' Use consistent quotes, either ' or " > + > +additionalProperties: false This should be unevaluatedProperties: false after referencing mentioned earlier thermal-sensor yaml Best regards, Krzysztof
