Currently TCPM doesn't support responding to Get_Revision request message. However, as per Message Applicability in USB PD Spec 3.1 v1.8 ("6.13.2 Applicability of Data Messages") "Revision" is a Normative (compulsory) message and needs to be supported. As part of this patchset add support for responding to Get_Revision requests as part of Revision_Information AMS. Signed-off-by: Amit Sunil Dhamne <amitsd@xxxxxxxxxx> --- Changes in v2: - Added maxItems constraint to "pd-revision" property - Link to v1: https://lore.kernel.org/r/20241205-get_rev_upstream-v1-0-90158ee7d75f@xxxxxxxxxx --- Amit Sunil Dhamne (3): dt-bindings: connector: Add pd-revision property usb: typec: tcpm: Add support for parsing pd-revision DT property usb: typec: tcpm: Add new AMS for Get_Revision response .../bindings/connector/usb-connector.yaml | 7 ++ .../devicetree/bindings/usb/maxim,max33359.yaml | 1 + drivers/usb/typec/tcpm/tcpm.c | 87 +++++++++++++++++++++- include/linux/usb/pd.h | 22 +++++- 4 files changed, 112 insertions(+), 5 deletions(-) --- base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 change-id: 20241205-get_rev_upstream-6b60000630af Best regards, -- Amit Sunil Dhamne <amitsd@xxxxxxxxxx>