Re: [PATCH 1/3] dt-bindings: connector: Add pd-revision property

Amit Sunil Dhamne <amitsd@xxxxxxxxxx> · Tue, 10 Dec 2024 18:55:34 -0800

Hi Rob,

On 12/10/24 3:06 PM, Rob Herring wrote:
On Thu, Dec 05, 2024 at 11:46:08PM -0800, Amit Sunil Dhamne wrote:
Add pd-revision property definition, to specify the maximum Power
Delivery Revision and Version supported by the connector.

Signed-off-by: Amit Sunil Dhamne <amitsd@xxxxxxxxxx>
---
  Documentation/devicetree/bindings/connector/usb-connector.yaml | 6 ++++++
  Documentation/devicetree/bindings/usb/maxim,max33359.yaml      | 1 +
  2 files changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index 67700440e23b5b7ca0db2c395c8a455bcf650864..341d2872e8d43450d219b7b72d48790051dc4e2b 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -293,6 +293,12 @@ properties:
        PD negotiation till BC1.2 detection completes.
      default: 0
  
+  pd-revision:
+    description: Specifies the maximum USB PD revision and version supported by
+      the connector. This property is specified in the following order;
+      <revision_major, revision_minor, version_major, version_minor>.
+    $ref: /schemas/types.yaml#/definitions/uint8-array
Always exactly 4 entries? Then:

maxItems: 4

Thanks for the catch! Updating it in the next revision.

Regards,

Amit

+
  dependencies:
    sink-vdos-v1: [ sink-vdos ]
    sink-vdos: [ sink-vdos-v1 ]
diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
index 20b62228371bdedf2fe92767ffe443bec87babc5..350d39fbf2dcd4d99db07cb8f099467e6fc653ee 100644
--- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
+++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
@@ -70,6 +70,7 @@ examples:
                                         PDO_FIXED_DUAL_ROLE)
                                         PDO_FIXED(9000, 2000, 0)>;
                  sink-bc12-completion-time-ms = <500>;
+                pd-revision = /bits/ 8 <0x03 0x01 0x01 0x08>;
              };
          };
      };

--
2.47.0.338.g60cca15819-goog








