On Mon, Dec 09, 2024 at 02:44:21PM +0100, Christian Marangi wrote: > +properties: > + compatible: > + const: airoha,an8855-mfd After assisting dt-binding reviews in the past, I get the impression that "mfd" in a compatible string name is not going to be accepted. The bindings should be OS-independent, MFD is a Linux implementation. In principle this could be just "airoha,an8855" for the entire SoC. > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mfd@1 { And the node name could be just "soc@1". > + compatible = "airoha,an8855-mfd"; > + reg = <1>; > + > + efuse { ... > + }; > + > + ethernet-switch { ... > + }; > + > + mdio { ... > + }; > + }; > + }; I hope it's not mandatory to duplicate in the example also the bindings of the children, especially since you link to their own schemas.