On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote: > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 > are actually powered by &vreg_l2j_1p2. > > Since most X1E device trees just mirror the power supplies from the > x1e80100-crd device tree, this series fixes up all the X1E boards with > the same change. Nice find! I've confirmed that this matches both the CRD and T14s schematics. > Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx> > Stephan Gerhold (8): > arm64: dts: qcom: x1e001de-devkit: Fix USB QMP PHY supplies > arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix USB QMP PHY supplies nit: We've been using the shorter "x1e78100-t14s" prefix for this one so far. This may apply to some of the others as well. > arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies > arm64: dts: qcom: x1e80100-crd: Fix USB QMP PHY supplies > arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies > arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix USB QMP PHY supplies > arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies > arm64: dts: qcom: x1e80100-qcp: Fix USB QMP PHY supplies Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx> Johan