On Tue, Dec 10, 2024 at 09:54:09AM +0800, Andy Yan wrote: > > Hi Dmitry, > > 在 2024-12-10 09:45:11，"Dmitry Baryshkov" <dmitry.baryshkov@xxxxxxxxxx> 写道： > >On Tue, 10 Dec 2024 at 03:22, Andy Yan <andyshrk@xxxxxxx> wrote: > >> > >> > >> Hi Dmitry, > >> > >> 在 2024-12-10 09:01:38，"Dmitry Baryshkov" <dmitry.baryshkov@xxxxxxxxxx> 写道： > >> >On Tue, Dec 10, 2024 at 08:50:51AM +0800, Andy Yan wrote: > >> >> > >> >> > >> >> Hi, > >> >> > >> >> At 2024-12-10 07:12:26, "Heiko Stübner" <heiko@xxxxxxxxx> wrote: > >> >> >Am Montag, 9. Dezember 2024, 17:11:03 CET schrieb Diederik de Haas: > >> >> >> Hi, > >> >> >> > >> >> >> On Mon Dec 9, 2024 at 4:06 PM CET, Daniel Semkowicz wrote: > >> >> >> > On 03.12.24 21:54, Heiko Stuebner wrote: > >> >> >> > > This series adds a bridge and glue driver for the DSI2 controller found > >> >> >> > > in the rk3588 soc from Rockchip, that is based on a Synopsis IP block. > >> >> >> > > > >> >> >> > > >> >> >> > I did more tests with different LVDS displays. I tested following > >> >> >> > configurations with DSI/LVDS bridge: > >> >> >> > - 1024x600@60.01 > >> >> >> > - 1024x768@60.02 > >> >> >> > - 1280x800@60.07 > >> >> >> > - 1366x768@60.06 > >> >> >> > > >> >> >> > All of them worked without issues, except 1366x768. > >> >> >> > With this resolution, video is blurry, and offset incorrectly > >> >> >> > to the left. There are also repeating errors on the console: > >> >> >> > > >> >> >> > rockchip-drm display-subsystem: [drm] *ERROR* POST_BUF_EMPTY irq err at vp3 > >> >> >> > > >> >> >> > In correct operation with other resolutions, there is no error. > >> >> >> > I am not sure if this is a problem in your series or rather in VOP2 > >> >> >> > driver. > >> >> > > >> >> >This really sounds like something is wrong on the vop side. > >> >> >The interrupt is part of the vop, the divisable by 4 things likely too. > >> >> > >> >> This is a hardware limitation on vop side: > >> >> The horizontal resolution must be 4 pixel aligned. > >> > > >> >Then mode_valid() and atomic_check() must reject modes that don't fit. > >> > >> We round down to 4 pixel aligned in mode_fixup in our bsp kernel, > > > >What is meant by the "bsp kernel" here? I don't see it being present > > bsp kernel means downstream vendor kernel. > > >in the mainline kernel. So, if the mode is unsupported, it should be > > Will it be acceptable to add this round down in the mainline mode_fixup? I think so. > > >rejected. > > > >> because sometimes, some boards do indeed choose a screen that is not 4 pixel aligned -- With best wishes Dmitry
