On Wed, Dec 04, 2024 at 11:52:34AM +0100, Neil Armstrong wrote: > + realtek,dmic-delay-ms: > + description: > + Set the delay time (ms) for the requirement of the particular DMIC. > + > + realtek,amic-delay-ms: > + description: > + Set the delay time (ms) for the requirement of the particular platform or AMIC. Please wrap at 80. This wasn't present in the old binding, so mention reason of adding it in the commit msg. > + > + realtek,dmic-clk-driving-high: > + type: boolean > + description: > + Set the high driving of the DMIC clock out. > + > + clocks: > + items: > + - description: phandle and clock specifier for codec MCLK. ... > + > + DBVDD-supply: > + description: Regulator supplying I/O power through the DBVDD pin. > + > + LDO1-IN-supply: > + description: Regulator supplying power to the digital core and charge pump > + through the LDO1_IN pin. > + > +unevaluatedProperties: false And since I expect a new version: please move unevaluatedProps after required: block. > + > +required: > + - compatible > + - reg > + - AVDD-supply > + - VBAT-supply > + - MICVDD-supply > + - DBVDD-supply > + - LDO1-IN-supply Best regards, Krzysztof
