Hello Peter,
On 2024-12-10 02:30, Peter Geis wrote:
Remove the ethernet alias added back in during the rk3328-roc dtsi
conversion.
I just checked again the dtsi parent conversion I performed in
the commit f3c6526d6fb2 ("arm64: dts: rockchip: Convert dts files
used as parents to dtsi files"), and both rk3328-roc-cc.dts and
rk3328-roc-pc.dts had the ethernet0 alias defined before the
conversion. Thus, the alias wasn't added back by mistake during
the conversion, it was there before.
Moreover, I don't see why would we want to delete the ethernet0
alias(es) in the first place? It's usual for Rockchip board dts
files to have ethernetX aliases defined, and both ROC-RK3328-CC
and ROC-RK3328-PC have their gmac2io DT nodes enabled, and the
boards have wired Ethernet ports, so they should also have the
ethernet0 alias(es) defined.
Am I missing something?
Fixes: f3c6526d6fb2 ("arm64: dts: rockchip: Convert dts files used as
parents to dtsi files")
Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx>
---
arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
index b5bd5e7d5748..f782c8220dd3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
@@ -9,7 +9,6 @@
/ {
aliases {
- ethernet0 = &gmac2io;
mmc0 = &sdmmc;
mmc1 = &emmc;
};
