On Fri, Dec 06, 2024 at 01:49:51PM +0100, Krzysztof Kozlowski wrote: > On 06/12/2024 13:14, Konrad Dybcio wrote: > >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>> new file mode 100644 > >>>> index 000000000000..a04c8d1fa258 > >>>> --- /dev/null > >>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>> @@ -0,0 +1,12 @@ > >>>> +// SPDX-License-Identifier: BSD-3-Clause > >>>> +/* > >>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > >>>> + */ > >>>> +/dts-v1/; > >>>> + > >>>> +#include "sa8775p-ride-r3.dts" > >>> No guys, you are making these things up. This is EXACTLY the same as > >>> qcs9100. > >> > >> 9100 & 9075 are different from “safe” perspective. They differ in > >> changes related to thermal which will be added later in devicetree. > > > > Since this can't be inferred from just looking at the changes, please > > make sure to add that to the commit message > > Any include of other DTS is clear sign something is odd here. Including > multiple times without any added nodes is showing these are not real > products/boards . We're adding DTS to reuse the common board changes, with plans to include the differences in upcoming patches. To provide more clarity, I will include patches in this series to highlight the differences between the 9100 and 9075 boards. > Best regards, > Krzysztof Thanks & Regards, Wasim
