> > I would of preferred MDIO_MMD_VEND2 rather than DP83822_DEVADDR, but > > having just this one instance correct would look a bit odd. > > > Is it worth fixing it in a separate patch, replacing all DP83822_DEVADDR > with MDIO_MMD_VEND2 ? You could do. As a reviewer, i like to be able to quickly see, these are vendor registers, i don't need to check if they are part of 802.3, and should have standard names, and be pulled out into a library for others to share. So if you want to add a patch, i'm happy with that. Andrew
